- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
Backup restore Bug fix #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup restore Bug fix #136
Conversation
| - Example deletion_timestamp="20241230_120000" with name="DAILY_BACKUP" | ||
| deletes backups starting with "DAILY_BACKUP" created before Dec 30, 2024 12:00:00. | ||
| - Ignored when delete_all_backup=true is specified. | ||
| type: str | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timestamp is tricky and needs to be updated everytime. We discussed to have a duration fields where user can mention older_than : 1 day or 5days and all backup older then that times get deleted. We need that functionality. timestamp also you can keep but it is not addressing the requirement. backup_retention_days: If this is provided with delete, all backup which are created in this period will be retained and older backup will be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove timestamp also it, just backup_retention_days is good to handle all config as code mode.
| dnac_task_poll_interval: 1 | ||
| state: deleted | ||
| config: | ||
| - backup_job_creation: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backup_job_creation, this parameter should be renamed. we don;t use module just to create the job, but full backup. So the name should be just backup.
ef218a3
      into
      
  
    cisco-en-programmability:main
  
    
Type of Change
Description
2 Bugs & 1 Enhancement feature done.
Bug Fix:
Following bugs fixed:
Root Cause (if applicable): NA
Fix Implemented:
Enhancement:
Enhancement Description:
- When generate_new_backup set to true, the system always creates a new backup. The provided backup name is used as a prefix, and a timestamp suffix is automatically appended to ensure uniqueness.
- When generate_new_backup set to false (or left unspecified), the system uses the exact backup name as provided and enforces idempotent behaviour, avoiding duplicate backups with the same name.
- When backup_retention_days is specified,
- Retains backups created within the specified number of days and deletes older backups.
- When used with name parameter, applies retention policy only to backups matching the name prefix.
- When used alone, applies retention policy to all backups.
Impact Area: NA
Testing Done:
Test cases covered: [Mention test case IDs or brief points]
Checklist
Ansible Best Practices
ansible-vaultor environment variables)Documentation
Screenshots (if applicable)
Notes to Reviewers